Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share type sciencemesh #37139

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Share type sciencemesh #37139

merged 2 commits into from
Mar 8, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Mar 8, 2023

Local copy of #36228 to be able to push changes.

Signed-off-by: Michiel de Jong <michiel@unhosted.org>
@artonge artonge added enhancement 3. to review Waiting for reviews javascript php Pull requests that update Php code labels Mar 8, 2023
@artonge artonge self-assigned this Mar 8, 2023
@artonge artonge added this to the Nextcloud 27 milestone Mar 8, 2023
@artonge artonge mentioned this pull request Mar 8, 2023
Signed-off-by: Louis Chemineau <louis@chmn.me>
*/
private function getSciencemeshShareHelper() {
if (!$this->appManager->isEnabledForUser('sciencemesh')) {
throw new QueryException();

Check notice

Code scanning / Psalm

DeprecatedClass

OCP\AppFramework\QueryException is marked deprecated
*/
private function getSciencemeshShareHelper() {
if (!$this->appManager->isEnabledForUser('sciencemesh')) {
throw new QueryException();

Check notice

Code scanning / Psalm

DeprecatedClass

OCP\AppFramework\QueryException is marked deprecated
@AndyScherzinger
Copy link
Member

/backport to stable26

@juliusknorr juliusknorr merged commit 127af09 into master Mar 8, 2023
@juliusknorr juliusknorr deleted the share-type-sciencemesh branch March 8, 2023 17:30
@mickenordin
Copy link
Contributor

Would it be possible to get this backported to stable25 as well? Seeing that 26 is still 6 months away for enterprise customers?

@AndyScherzinger
Copy link
Member

26 enterprise is planned for next month given 26 is is then considered enterprise-ready

@AndyScherzinger
Copy link
Member

/backport to stable25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement javascript php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants