Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a check for disk_free_space in Config.php #37070

Merged
merged 1 commit into from
Mar 9, 2023
Merged

add a check for disk_free_space in Config.php #37070

merged 1 commit into from
Mar 9, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Mar 7, 2023 •
edited
Loading

@szaimen szaimen added bug 3. to review Waiting for reviews labels Mar 7, 2023
@szaimen szaimen added this to the Nextcloud 27 milestone Mar 7, 2023
@szaimen szaimen requested review from a team, ArtificialOwl, icewind1991 and come-nc and removed request for a team March 7, 2023 08:51
@szaimen
Copy link
Contributor Author

szaimen commented Mar 7, 2023

/backport to stable26

@szaimen
Copy link
Contributor Author

szaimen commented Mar 7, 2023

/backport to stable25

@szaimen
Copy link
Contributor Author

szaimen commented Mar 7, 2023

/backport to stable24

@szaimen szaimen mentioned this pull request Mar 7, 2023
Merged
4 tasks
@szaimen szaimen requested a review from solracsf March 7, 2023 08:53
@szaimen
Copy link
Contributor Author

szaimen commented Mar 7, 2023

/rebase

@szaimen
add a check for disk_free_space in Config.php
e87d968 
Signed-off-by: Simon L <szaimen@e.mail.de>
@nextcloud-command nextcloud-command force-pushed the enh/noid/add-free-disk-space-check branch from 16582a0 to e87d968 Compare March 7, 2023 09:43
artonge
artonge approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When does the disk_free_space function not exist ?

@szaimen
Copy link
Contributor Author

szaimen commented Mar 9, 2023 •
edited
Loading

When does the disk_free_space function not exist ?

If it is whyever disabled by the admin...

@come-nc
Copy link
Contributor

come-nc commented Mar 9, 2023

When does the disk_free_space function not exist ?

If it is whyever disabled by the admin...

You had an actual usecase or is that extra caution?
Because any function can be disabled in php.ini and we cannot test all functions we use.

@szaimen
Copy link
Contributor Author

szaimen commented Mar 9, 2023

You had an actual usecase or is that extra caution?
Because any function can be disabled in php.ini and we cannot test all functions we use.

#37062 (comment)

@szaimen
Copy link
Contributor Author

szaimen commented Mar 9, 2023

CI failure unrelated

@szaimen szaimen merged commit 694f743 into master Mar 9, 2023
@szaimen szaimen deleted the enh/noid/add-free-disk-space-check branch March 9, 2023 09:24
@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Mar 9, 2023

/backport to stable26

@szaimen
Copy link
Contributor Author

szaimen commented Mar 9, 2023

/backport to stable25

@szaimen
Copy link
Contributor Author

szaimen commented Mar 9, 2023

/backport to stable24

This was referenced Mar 9, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@solracsf solracsf Awaiting requested review from solracsf

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
3 participants
@szaimen @come-nc @artonge