Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to revert automated status #36854

Merged
merged 8 commits into from
Apr 18, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 24, 2023

Summary

DND because of Availability Away because of "In call"
Peek 2023-02-27 21-50 Peek 2023-02-27 21-52

TODO

  • Allow to manually revert the status when it was set by "Availability" or "Joining a call"

Follow up

  • Currently requires a page reload before, as the "messageId" is only populated via initial state and not transmitted by any other API calls and therefore not updated "live" (e.g. when joining a call the reset button is not visible in the same window) => "Revert automatic status" not always visible #37733

Checklist

@nickvergessen nickvergessen added the 2. developing Work in progress label Feb 24, 2023
@nickvergessen nickvergessen added this to the Nextcloud 27 milestone Feb 24, 2023
@nickvergessen nickvergessen self-assigned this Feb 24, 2023
@nimishavijay
Copy link
Member

nimishavijay commented Feb 24, 2023

Good idea 👍🏽 For the UI we could do it like this:

  • Show the current status and emoji in status input field (because that is where people would look first for the current status)
  • Show "Your status was set automatically" as a subline below the input field (info when people are confused that their status has changed)
  • Show previous status as the first entry in the list of predefined statuses (visually follows the pattern of the list of statuses while still being easy to find because it's the first entry)
  • Show a reset button on the right of the previous status (doesn't take up too much vertical space)
  • When you click on "reset" button it will be reflected in the contents of the status input field and the emoji

Rough idea of the layout:

cc @jancborchardt

@nickvergessen
Copy link
Member Author

When you click on "reset" button it will be reflected in the contents of the status input field and the emoji

Is it okay to directly "save" this as well? That would be easier as we can restore the old online-status, emoji, message and clear-at with a single request instead of having to do multiple requests later on.

Current state sample gifs

DND because of Availability Away because of "In call"
Peek 2023-02-27 21-50 Peek 2023-02-27 21-52

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! To make it a bit less jumpy as @nimishavijay noted, it would be good to add a little animation here. Best of the row you click "Reset" on moving up and fading away, sort of so it fades into the input field. :)

@nickvergessen
Copy link
Member Author

Best of the row you click "Reset" on moving up and fading away, sort of so it fades into the input field. :)

I'm not a frontender so can't help with that. The other option I would see is closing the modal which also happens when "Set status message" is used.

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice as is now, the animation could be something for the future. Nice one @nickvergessen! :)

nickvergessen and others added 8 commits April 18, 2023 14:57
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
…he store

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feature/36852/allow-to-revert-automated-status branch from b48d718 to 63dc8cb Compare April 18, 2023 13:08
@nickvergessen nickvergessen merged commit a3e854b into master Apr 18, 2023
@nickvergessen nickvergessen deleted the feature/36852/allow-to-revert-automated-status branch April 18, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing action to revert the status back after an auto change in calendar/talk
4 participants