Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(autoloading): Add authoritative autoloader for theming #36652

Merged
merged 2 commits into from
Apr 3, 2023
Merged

perf(autoloading): Add authoritative autoloader for theming #36652

merged 2 commits into from
Apr 3, 2023

Conversation

ChristophWurst
Copy link
Member

  • Resolves: #

Summary

Improves autoloading performance. Benchmarks in #36112.

TODO

  • Add composer config
  • Update autoloaders

Checklist

@ChristophWurst ChristophWurst added this to the Nextcloud 26 milestone Feb 10, 2023
@ChristophWurst ChristophWurst self-assigned this Feb 10, 2023
@ChristophWurst ChristophWurst mentioned this pull request Feb 10, 2023
Closed
4 tasks
@ChristophWurst
Copy link
Member Author

CI fails because of 4e1d501

@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 7, 2023
@ChristophWurst ChristophWurst marked this pull request as ready for review March 17, 2023 13:25
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 17, 2023
come-nc
come-nc approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@juliusknorr
Copy link
Member

@ChristophWurst Mind to rebase?

@ChristophWurst ChristophWurst force-pushed the perf/autoloading/theming-authoritative-autoloader branch from 8ab04ae to 2091269 Compare March 27, 2023 10:53
@ChristophWurst
Copy link
Member Author

Previous rebase went bad. Sorry.

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 27, 2023
@ChristophWurst
perf(autoloading): Add authoritative autoloader for theming
d5dcf7a 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
Revert "Dark autoloader magic for ThemingDefaults"
44dc839 
This reverts commit 4e1d501.
@ChristophWurst ChristophWurst force-pushed the perf/autoloading/theming-authoritative-autoloader branch from 2091269 to 44dc839 Compare March 27, 2023 10:57
@ChristophWurst
Copy link
Member Author

E2E cypress fails. Can I ignore that?

@ChristophWurst ChristophWurst mentioned this pull request Mar 30, 2023
Merged
6 tasks
@juliusknorr
Copy link
Member

Looks unrelated, but restarted them as I haven't seen that specific error before.

@ChristophWurst ChristophWurst enabled auto-merge April 3, 2023 06:56
@rullzer
Copy link
Member

rullzer commented Apr 3, 2023

E2E cypress fails. Can I ignore that?

Yes

@juliusknorr
Copy link
Member

Usual failure now

@juliusknorr juliusknorr disabled auto-merge April 3, 2023 08:37
@juliusknorr juliusknorr merged commit 671d272 into master Apr 3, 2023
@juliusknorr juliusknorr deleted the perf/autoloading/theming-authoritative-autoloader branch April 3, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@rullzer rullzer rullzer approved these changes

@vitormattos vitormattos Awaiting requested review from vitormattos

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish performance 🚀
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
5 participants
@ChristophWurst @juliusknorr @rullzer @come-nc @blizzz