-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add events to QueryBuilder
class
#36572
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90 changes: 90 additions & 0 deletions
90
lib/public/DB/QueryBuilder/Events/BeforeQueryExecutedEvent.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/** | ||
* @copyright Copyright (c) 2023 Andrew Summers | ||
* | ||
* @author Andrew Summers | ||
* | ||
* @license GNU AGPL version 3 or any later version | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License as | ||
* published by the Free Software Foundation, either version 3 of the | ||
* License, or (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
* | ||
*/ | ||
|
||
namespace OCP\DB\QueryBuilder\Events; | ||
|
||
use OCP\EventDispatcher\Event; | ||
use OCP\DB\QueryBuilder\IQueryBuilder; | ||
use Doctrine\DBAL\Result; | ||
|
||
/** | ||
* This event is used by apps to intercept, inspect, and potentially modify | ||
* database queries prior to execution. This can be used for deep integrations, | ||
* restricting user access to certain data, redacting information, etc. | ||
* | ||
* The result field can optionally be set by the event listener by executing the | ||
* query in the event handler logic. This allows apps to inspect the results, | ||
* use try/catch blocks around the query execution, and/or modify/re-execute the | ||
* query if necessary. If the result field is not set, the QueryBuilder class | ||
* will execute the query as expected by default. | ||
* | ||
* @see https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/projects.html | ||
* @since 28.0.0 | ||
*/ | ||
class BeforeQueryExecutedEvent extends Event { | ||
private IQueryBuilder $queryBuilder; | ||
private $result = null; | ||
|
||
/** | ||
* @param IQueryBuilder $queryBuilder | ||
* @since 28.0.0 | ||
*/ | ||
public function __construct(IQueryBuilder $queryBuilder) { | ||
$this->queryBuilder = $queryBuilder; | ||
} | ||
|
||
/** | ||
* @return IQueryBuilder | ||
* @since 28.0.0 | ||
*/ | ||
public function getQueryBuilder(): IQueryBuilder { | ||
return $this->queryBuilder; | ||
} | ||
|
||
/** | ||
* @param IQueryBuilder $queryBuilder | ||
* @since 28.0.0 | ||
*/ | ||
public function setQueryBuilder(IQueryBuilder $queryBuilder) { | ||
$this->queryBuilder = $queryBuilder; | ||
} | ||
|
||
/** | ||
* @return Result|int|string | ||
* @since 28.0.0 | ||
*/ | ||
public function getResult() { | ||
return $this->result; | ||
} | ||
|
||
/** | ||
* @param Result|int|string $result | ||
* @since 28.0.0 | ||
*/ | ||
public function setResult($result) { | ||
$this->result = $result; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/** | ||
* @copyright Copyright (c) 2023 Andrew Summers | ||
* | ||
* @author Andrew Summers | ||
* | ||
* @license GNU AGPL version 3 or any later version | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License as | ||
* published by the Free Software Foundation, either version 3 of the | ||
* License, or (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
* | ||
*/ | ||
|
||
namespace OCP\DB\QueryBuilder\Events; | ||
|
||
use OCP\EventDispatcher\Event; | ||
use OCP\DB\QueryBuilder\IQueryBuilder; | ||
use Doctrine\DBAL\Result; | ||
|
||
/** | ||
* This event is used by apps to intercept, inspect, and potentially modify | ||
* the results of database queries after execution. This can be used for deep | ||
* integrations, restricting user access to certain data, redacting information, | ||
* etc. | ||
* | ||
* @see https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/projects.html | ||
* @since 28.0.0 | ||
*/ | ||
class QueryExecutedEvent extends Event { | ||
private IQueryBuilder $queryBuilder; | ||
private $result; | ||
|
||
/** | ||
* @param IQueryBuilder $queryBuilder | ||
* @param $result | ||
* @since 28.0.0 | ||
*/ | ||
public function __construct(IQueryBuilder $queryBuilder, $result) { | ||
$this->queryBuilder = $queryBuilder; | ||
$this->result = $result; | ||
} | ||
|
||
/** | ||
* @return IQueryBuilder | ||
* @since 28.0.0 | ||
*/ | ||
public function getQueryBuilder(): IQueryBuilder { | ||
return $this->queryBuilder; | ||
} | ||
|
||
/** | ||
* @param IQueryBuilder $queryBuilder | ||
* @since 28.0.0 | ||
*/ | ||
public function setQueryBuilder(IQueryBuilder $queryBuilder) { | ||
$this->queryBuilder = $queryBuilder; | ||
} | ||
|
||
/** | ||
* @return Result|int|string | ||
* @since 28.0.0 | ||
*/ | ||
public function getResult() { | ||
return $this->result; | ||
} | ||
|
||
/** | ||
* @param Result|int|string $result | ||
* @since 28.0.0 | ||
*/ | ||
public function setResult($result) { | ||
$this->result = $result; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
service locators should be avoided. would it be possible to directly inject the dispatcher as constructor argument?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I can make that happen. However, I'm going to push back a little. There are a number of places throughout Nextcloud where this exact method is used (many of which include you as an author, actually):
server/core/Application.php
Line 85 in 8b3b5ff
server/lib/private/Files/Cache/Cache.php
Line 127 in 8b3b5ff
server/apps/dav/lib/Server.php
Line 107 in 8b3b5ff
server/apps/dav/lib/RootCollection.php
Line 67 in 8b3b5ff
If I were to inject it as a constructor argument, I would need to edit anywhere the QueryBuilder is instantiated, correct (looks like
OC\DB\Connection
is the only place)?