Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(autoloading): Add authoritative autoloader for files_external #36469

Conversation

ChristophWurst
Copy link
Member

  • Resolves: #

Summary

Extracted from #36112 for green CI.

Checklist

@skjnldsv
Copy link
Member

skjnldsv commented Feb 1, 2023

Should we also have a dedicated workflow to check for outdated autoloaders here too?

@ChristophWurst
Copy link
Member Author

Should we also have a dedicated workflow to check for outdated autoloaders here too?

#36112 f4ff908 addresses that.

@ChristophWurst
Copy link
Member Author

Should we also have a dedicated workflow to check for outdated autoloaders here too?

We have a workflow to check for outdated workflows. The issue here is that they were missing. And the update script skips apps without an autoloader.

@ChristophWurst
Copy link
Member Author

**Samba Kerberos SSO / kerberos (pull_request) ** Failing after 1m

It wasn't me: https://github.com/nextcloud/server/actions/workflows/smb-kerberos.yml

@blizzz blizzz mentioned this pull request Feb 1, 2023
@ChristophWurst
Copy link
Member Author

Shall we do this?

@icewind1991
Copy link
Member

/rebase

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@nextcloud-command nextcloud-command force-pushed the perf/autoloading/files-external-authoritative-autoloader branch from b36a80a to a208cde Compare February 9, 2023 15:04
@ChristophWurst
Copy link
Member Author

Failed to connect to localhost port 9000 after 0 ms: Connection refused

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 9, 2023
@juliushaertl juliushaertl merged commit 6d77a53 into master Feb 9, 2023
@juliushaertl juliushaertl deleted the perf/autoloading/files-external-authoritative-autoloader branch February 9, 2023 19:49
@blizzz blizzz mentioned this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish performance 🚀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants