Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop vue-clipboard2 in favour of native Clipboard API to fix copy to clipboard #36450

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jan 31, 2023

Summary

Drop https://github.com/Inndy/vue-clipboard2 in favour of the native Clipboard API to copy to clipboard

According to the compatibility table https://developer.mozilla.org/en-US/docs/Web/API/Clipboard/writeText#browser_compatibility only mobile Safari >= 13.4 is compatible, so versions 12.2-12.5 which is targetted by our browserslist https://browserslist.dev/?q=PjAuMjUlLCBub3QgaWUgMTEsIG5vdCBvcF9taW5pIGFsbCwgbm90IGRlYWQsIEZpcmVmb3ggRVNS may not be supported

Before After
image image

Checklist

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Copy link
Member Author

Pytal commented Feb 1, 2023

/backport to stable25

Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now 🎉

@szaimen
Copy link
Contributor

szaimen commented Feb 2, 2023

CI failure unrelated

@szaimen szaimen merged commit 6f3c4f2 into master Feb 2, 2023
@szaimen szaimen deleted the fix/clipboard-copy branch February 2, 2023 15:05
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Feb 2, 2023

The backport to stable25 failed. Please do this backport manually.

Details
# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

#36507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants