CORS should only be bypassed on PublicPage if not logged in
#36396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
a team,
ArtificialOwl,
icewind1991,
blizzz and
nickvergessen
and removed request for
a team
Merged
|
Any update on this one? Something I can help with? |
nickvergessen
approved these changes
Feb 8, 2023
juliushaertl
approved these changes
Feb 16, 2023
|
Restarted drone since the history was gone |
seems related :/ |
… in to prevent CSRF attack vectors Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
The exception is expected, fixed the new test. |
Merged
susnux
added a commit
to nextcloud/forms
that referenced
this pull request
Mar 20, 2024
This was fixed in Nextcloud 26+, ref: nextcloud/server#36396 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added a commit
to nextcloud/forms
that referenced
this pull request
Mar 22, 2024
This was fixed in Nextcloud 26+, ref: nextcloud/server#36396 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added a commit
to nextcloud/forms
that referenced
this pull request
Mar 22, 2024
This was fixed in Nextcloud 26+, ref: nextcloud/server#36396 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Chartman123
pushed a commit
to nextcloud/forms
that referenced
this pull request
Mar 22, 2024
This was fixed in Nextcloud 26+, ref: nextcloud/server#36396 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To prevent CSRF attack vectors CORS should only be bypassed if not logged in on
@PublicPage.If you add the
CORSannotation you would expect all users to be validated even on@PublicPage, e.g. for APIs where anonymous users can submit data but also logged in users, currently there is no protection against CSRF on those API endpoints.Checklist