Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] fix admin-disabled background and user pristine theming settings #36394

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 26, 2023

Summary

Only for 25, because it's a mess and we fixed in 26 already

Reproducing the issue:

  1. Install 25
  2. Change admin background color
  3. Remove admin background image
  4. With a clean user, have the proper colour but the cloud background is applied.

Checklist

… settings

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added this to the Nextcloud 25.0.4 milestone Jan 26, 2023
@skjnldsv skjnldsv requested a review from a team January 26, 2023 18:58
@skjnldsv skjnldsv self-assigned this Jan 26, 2023
@skjnldsv skjnldsv requested review from artonge, Pytal, szaimen and PVince81 and removed request for a team January 26, 2023 18:58
@skjnldsv skjnldsv changed the title fix(theming): fix admin-disabled background and user pristine theming settings [stable25] fix admin-disabled background and user pristine theming settings Jan 27, 2023
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works

@szaimen
Copy link
Contributor

szaimen commented Jan 27, 2023

Can someone restart drone?

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 27, 2023
@skjnldsv skjnldsv merged commit 13fdb06 into stable25 Jan 29, 2023
@skjnldsv skjnldsv deleted the stable25-fix-theming-bg-disabled branch January 29, 2023 10:25
@blizzz blizzz mentioned this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: theming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants