cloud_federation_api: Introduce OpenAPI spec #36356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
nickvergessen,
PVince81,
ChristophWurst,
juliushaertl and
tobiasKaminsky
apps/cloud_federation_api/lib/Model/CloudFederationAddShare.response.php
Outdated
Show resolved
Hide resolved
come-nc
reviewed
Jan 26, 2023
apps/cloud_federation_api/lib/Model/CloudFederationAddShare.response.php
Outdated
Show resolved
Hide resolved
provokateurin
force-pushed
the
feature/cloud_federation_api-openapi
branch
from
65e8e58
to
8ec7eec
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
apps/cloud_federation_api/lib/Model/CloudFederationAddShare.php
Outdated
Show resolved
Hide resolved
apps/cloud_federation_api/lib/Model/CloudFederationAddShare.php
Outdated
Show resolved
Hide resolved
apps/cloud_federation_api/lib/Model/CloudFederationAddShare.php
Outdated
Show resolved
Hide resolved
apps/cloud_federation_api/lib/Model/CloudFederationAddShare.php
Outdated
Show resolved
Hide resolved
apps/cloud_federation_api/lib/Model/CloudFederationAddShare.php
Outdated
Show resolved
Hide resolved
apps/cloud_federation_api/lib/Model/CloudFederationAddShare.php
Outdated
Show resolved
Hide resolved
provokateurin
force-pushed
the
feature/cloud_federation_api-openapi
branch
from
8ec7eec
to
23f5f78
Compare
provokateurin
force-pushed
the
feature/cloud_federation_api-openapi
branch
from
23f5f78
to
14c9c4f
Compare
come-nc
reviewed
Jan 30, 2023
apps/cloud_federation_api/lib/Model/Response/CloudFederationValidationError.php
Outdated
Show resolved
Hide resolved
provokateurin
force-pushed
the
feature/cloud_federation_api-openapi
branch
from
14c9c4f
to
f836c7c
Compare
provokateurin
force-pushed
the
feature/cloud_federation_api-openapi
branch
from
f836c7c
to
0a29f3b
Compare
provokateurin
force-pushed
the
feature/cloud_federation_api-openapi
branch
3 times, most recently
from
40c8398
to
cc06bb5
Compare
Merged
provokateurin
force-pushed
the
feature/cloud_federation_api-openapi
branch
from
cc06bb5
to
6d44de2
Compare
| * | ||
| * Example: curl -H "Content-Type: application/json" -X POST -d '{"shareWith":"admin1@serve1","name":"welcome server2.txt","description":"desc","providerId":"2","owner":"admin2@http://localhost/server2","ownerDisplayName":"admin2 display","shareType":"user","resourceType":"file","protocol":{"name":"webdav","options":{"sharedSecret":"secret","permissions":"webdav-property"}}}' http://localhost/server/index.php/ocm/shares | ||
| */ | ||
| public function addShare($shareWith, $name, $description, $providerId, $owner, $ownerDisplayName, $sharedBy, $sharedByDisplayName, $protocol, $shareType, $resourceType) { | ||
| public function addShare(string $shareWith, string $name, ?string $description, string $providerId, string $owner, ?string $ownerDisplayName, ?string $sharedBy, ?string $sharedByDisplayName, array $protocol, string $shareType, string $resourceType): JSONResponse { |
Check failure
Code scanning / Psalm
InvalidDocblock
| */ | ||
| public function receiveNotification($notificationType, $resourceType, $providerId, array $notification) { | ||
| public function receiveNotification(string $notificationType, string $resourceType, ?string $providerId, ?array $notification): JSONResponse { |
Check failure
Code scanning / Psalm
InvalidDocblock
provokateurin
force-pushed
the
feature/cloud_federation_api-openapi
branch
2 times, most recently
from
1a874a9
to
1219a04
Compare
Signed-off-by: jld3103 <jld3103yt@gmail.com>
provokateurin
force-pushed
the
feature/cloud_federation_api-openapi
branch
from
1219a04
to
c5650b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adapts the code to make it friendly for https://github.com/nextcloud-gmbh/openapi-extractor and add the automatically generated spec.
TODO
Checklist