feat(app-framework): Add native argument types for middleware

[ChristophWurst]

Resolves: n/a

Summary

PHP allows us to add types to a base class that is extended elsewhere without breaking an interface: https://3v4l.org/JDX4H. So let's make use of this.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[nickvergessen]

But Psalm might cry?

[ChristophWurst]

But Psalm might cry?

Always has

[ChristophWurst]

But Psalm might cry?

Only INFO, no ERROR: https://psalm.dev/r/ccd19c3340

[ChristophWurst]

tests fail because we pass null as method name

[szaimen]

What is missing here?

[ChristophWurst]

tests fail because we pass null as method name

Test\AppFramework\Middleware\MiddlewareTest::testBeforeController
--


TypeError: 
OCP\AppFramework\Middleware::beforeController(): Argument #2 
($methodName) must be of type string, null given, called in 
/drone/src/tests/lib/AppFramework/Middleware/MiddlewareTest.php on line 
74

[nickvergessen]

So?

• Fix up
• Mark as ready to review
• Merge