fix(app-framework): Specify return type of Middleware::beforeController #36341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
requested review from
PVince81,
susnux,
miaulalala,
Linabroehm and
Antreesy
|
Tests are all happy. Let's do this? |
miaulalala
approved these changes
Jan 26, 2023
ChristophWurst
deleted the
fix/app-framework/middleware-before-controller-returns-void
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: n/a
Summary
The abstract class has no defined return type. Adding one makes it easier to write a correct subclass override for that method.
We can not add a PHP return type yet because that would potentially cause trouble with untyped subclasses: https://3v4l.org/dRU5Q
Checklist