Insert filecache data and conflict fallback read in the same transaction #36313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of an asynchronous replication database system, the inserted row might not yet be available in the replicated R/O database. Closes #21811 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
szaimen
requested review from
a team,
ArtificialOwl and
come-nc
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -271,7 +276,8 @@ | |||
| * @param array $data | |||
| * | |||
| * @return int file id | |||
| * @throws \RuntimeException | |||
| * @throws Exception | |||
Check failure
Code scanning / Psalm
UndefinedDocblockClass
come-nc
reviewed
Jan 24, 2023
| @@ -271,7 +276,8 @@ public function put($file, array $data) { | |||
| * @param array $data | |||
| * | |||
| * @return int file id | |||
| * @throws \RuntimeException | |||
| * @throws Exception | |||
There was a problem hiding this comment.
Suggested change
| * @throws Exception | |
| * @throws \Exception |
|
I’m not comfortable enough with the DB code to review that, I never used transactions |
tcitworld
added
2. developing
|
Needs investigation for the PostgreSQL failing tests. |
Merged
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
|
We are running with a rebased version of this in 27.1.9 now and the getId backtraces disappeared completely. We saw them for years now. Backend is a Galera Cluster with a Maxscale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the case of an asynchronous replication database system, the inserted row might not yet be available in the replicated R/O database.
This removes d918458 from @icewind1991 which shouldn't be needed anymore.
Best reviewed as https://github.com/nextcloud/server/pull/36313/files?diff=unified&w=1
Checklist