-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple session start calls #36239
Closed
Closed
Multiple session start calls #36239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
juliusknorr,
ChristophWurst,
a team,
ArtificialOwl,
icewind1991 and
blizzz
and removed request for
a team
January 19, 2023 09:18
Merged
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Merged
Signed-off-by: the-djmaze <3752035+the-djmaze@users.noreply.github.com>
This was referenced Mar 12, 2024
Merged
Merged
Merged
skjnldsv
added
2. developing
Work in progress
stale
Ticket or PR with no recent activity
and removed
3. to review
Waiting for reviews
labels
Jul 27, 2024
Merged
Hello @the-djmaze ! We're closing this PR as it seems that the original issue was solved with a different approach :) |
Good that it is solved 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OC\Session\Internal->clear() reopens the session several times as regenerateId() also reopens the sessions.
So it was like:
Secondly the sessionClosed wasn't handled properly as
read_and_close
might or might not be used.