Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add always visible share label #36130

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Add always visible share label #36130

merged 1 commit into from
Jan 13, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jan 12, 2023

Before After
image image

@Pytal
Add visible share label
41d7f9d 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added this to the Nextcloud 26 milestone Jan 12, 2023
@Pytal Pytal self-assigned this Jan 12, 2023
@Pytal Pytal mentioned this pull request Jan 12, 2023
Closed
6 tasks
@Pytal
Copy link
Member Author

Pytal commented Jan 12, 2023

/backport to stable25

szaimen
szaimen approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

PVince81
PVince81 approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit b88864b into master Jan 13, 2023
@PVince81 PVince81 deleted the enh/a11y-share-link-label branch January 13, 2023 09:22
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 13, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@szaimen szaimen szaimen approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility feature: sharing
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @PVince81 @szaimen