Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Use mimetype from cache for workflow checks #35842

Merged
merged 3 commits into from
Feb 9, 2023
Merged

[stable25] Use mimetype from cache for workflow checks #35842

merged 3 commits into from
Feb 9, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #25768

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 25.0.3 milestone Dec 20, 2022
PVince81
PVince81 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skjnldsv skjnldsv mentioned this pull request Jan 6, 2023
Merged
5 tasks
@skjnldsv
Copy link
Member

skjnldsv commented Jan 6, 2023

/rebase

@skjnldsv
Copy link
Member

skjnldsv commented Jan 6, 2023

Lots of failures

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Jan 6, 2023
@LukasReschke LukasReschke removed their request for review January 6, 2023 17:15
This was referenced Jan 11, 2023
Merged
Merged
@blizzz blizzz mentioned this pull request Feb 6, 2023
Merged
@blizzz
Copy link
Member

blizzz commented Feb 7, 2023

/rebase

@icewind1991 @blizzz
use mimetype from cache for workflow if available
e48d503 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @blizzz
remove file exists check from cacheAndReturnMimeType
8b39345 
the method is only called if the file exists already

a check against storing the fallback mimetype is added as a safety instead

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @blizzz
add some tests for mimetype check
4c60cdd 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 7, 2023
@blizzz blizzz enabled auto-merge February 7, 2023 17:45
@blizzz blizzz disabled auto-merge February 9, 2023 13:35
@blizzz blizzz merged commit 6a19833 into stable25 Feb 9, 2023
@blizzz blizzz deleted the backport/25768/stable25 branch February 9, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@icewind1991 icewind1991 icewind1991 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Milestone
Nextcloud 25.0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @blizzz @PVince81 @icewind1991