Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced app enable/disable/update typed events #35677

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Introduced app enable/disable/update typed events #35677

merged 1 commit into from
Mar 13, 2023

Conversation

tcitworld
Copy link
Member

@tcitworld tcitworld commented Dec 8, 2022 •
edited by ChristophWurst
Loading

OCP\App\ManagerEvent is depreciated since 22 in #25546 without a replacement

Checklist

@tcitworld tcitworld added 3. to review Waiting for reviews feature: apps management technical debt php Pull requests that update Php code labels Dec 8, 2022
@tcitworld tcitworld added this to the Nextcloud 26 milestone Dec 8, 2022
@tcitworld tcitworld requested review from ChristophWurst, come-nc and a team December 8, 2022 09:58
@tcitworld tcitworld requested review from skjnldsv and CarlSchwan and removed request for a team December 8, 2022 09:59
@skjnldsv
Copy link
Member

skjnldsv commented Dec 8, 2022 •
edited
Loading

Was there none prior this ? Or is there some old ones already available?
If so, can we also deprecate the old events?

@tcitworld
Copy link
Member Author

The old ones are using OCP\App\ManagerEvent which is depreciated since 22.

@tcitworld tcitworld force-pushed the add-typed-app-management-events branch from 2e1b276 to f4ee15b Compare December 8, 2022 10:16
@tcitworld tcitworld force-pushed the add-typed-app-management-events branch from f4ee15b to 56ac399 Compare December 8, 2022 11:12
@tcitworld tcitworld requested a review from come-nc December 8, 2022 11:12
@tcitworld tcitworld force-pushed the add-typed-app-management-events branch from 56ac399 to bf68763 Compare December 8, 2022 13:27
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Dec 13, 2022
@PVince81
Copy link
Member

please fix the psalm issues (static check)

@tcitworld tcitworld force-pushed the add-typed-app-management-events branch from bf68763 to 5e04230 Compare January 19, 2023 17:41
tcitworld added a commit to nextcloud/documentation that referenced this pull request Jan 20, 2023
@tcitworld
Add new app management events
d25e61e 
Reference: nextcloud/server#35677

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld mentioned this pull request Jan 20, 2023
Merged
@tcitworld
Copy link
Member Author

Psalm fixed and docs at nextcloud/documentation#9572

@ChristophWurst
Copy link
Member

Tests\Core\Command\User\SettingTest::testCheckInput

unrelated.

samba failure probably too

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 20, 2023
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@tcitworld tcitworld removed the pending documentation This pull request needs an associated documentation update label Mar 13, 2023
@tcitworld tcitworld force-pushed the add-typed-app-management-events branch from 5e04230 to c64dcbb Compare March 13, 2023 08:59
@tcitworld tcitworld mentioned this pull request Mar 13, 2023
Closed
5 tasks
@tcitworld
Introduced app enable/disable/update typed events
f1751c4 
OCP\App\ManagerEvent is depreciated since 22 without a replacement

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld force-pushed the add-typed-app-management-events branch from c64dcbb to f1751c4 Compare March 13, 2023 10:53
@szaimen
Copy link
Contributor

szaimen commented Mar 13, 2023

CI failure unrelated

@szaimen szaimen merged commit e450482 into master Mar 13, 2023
@szaimen szaimen deleted the add-typed-app-management-events branch March 13, 2023 20:33
tcitworld added a commit to nextcloud/documentation that referenced this pull request Mar 14, 2023
@tcitworld
Add new app management events
f23f1ee 
Reference: nextcloud/server#35677

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@szaimen szaimen szaimen left review comments

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: apps management php Pull requests that update Php code technical debt
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
8 participants
@tcitworld @skjnldsv @PVince81 @ChristophWurst @szaimen @CarlSchwan @come-nc @blizzz