Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus trap contacts menu with NcHeaderMenu port #35637

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Focus trap contacts menu with NcHeaderMenu port #35637

merged 1 commit into from
Jan 13, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Dec 7, 2022 •
edited
Loading

Wrap the existing contacts menu with NcHeaderMenu

@Pytal Pytal added this to the Nextcloud 26 milestone Dec 7, 2022
@Pytal Pytal self-assigned this Dec 7, 2022
@Pytal Pytal mentioned this pull request Dec 7, 2022
Closed
6 tasks
@Pytal Pytal force-pushed the enh/a11y-contacts-menu branch from e89a17b to b7a5bd3 Compare January 4, 2023 01:45
@Pytal Pytal mentioned this pull request Jan 4, 2023
Merged
@Pytal Pytal force-pushed the enh/a11y-contacts-menu branch from b7a5bd3 to a24d08d Compare January 12, 2023 01:36
@Pytal
Copy link
Member Author

Pytal commented Jan 12, 2023

Screenshotable after #36110

@Pytal Pytal changed the title [WIP] Focus trap contacts menu with NcHeaderMenu Focus trap contacts menu with NcHeaderMenu port Jan 12, 2023
@Pytal Pytal force-pushed the enh/a11y-contacts-menu branch 2 times, most recently from 3042a86 to 6eef6b9 Compare January 12, 2023 23:50
@Pytal Pytal marked this pull request as ready for review January 12, 2023 23:53
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 12, 2023
@Pytal
Copy link
Member Author

Pytal commented Jan 12, 2023

Code ready but unfortunately not screenshotable due to the reasons detailed in #36110

@Pytal
Copy link
Member Author

Pytal commented Jan 12, 2023

/backport to stable25

@Pytal
Copy link
Member Author

Pytal commented Jan 12, 2023

/compile amend /

@skjnldsv
Copy link
Member

Very clean :)

@skjnldsv
Copy link
Member

Tests are failing though 😢

@Pytal Pytal force-pushed the enh/a11y-contacts-menu branch from 3fa07f7 to 39dfc18 Compare January 13, 2023 17:45
@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 13, 2023
@Pytal Pytal force-pushed the enh/a11y-contacts-menu branch 2 times, most recently from 608f3ab to f3813c6 Compare January 13, 2023 20:14
@skjnldsv
Copy link
Member

acceptance-header still failing :)

@Pytal
Focus trap contacts menu with NcHeaderMenu port
f6aa522 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/a11y-contacts-menu branch from f3813c6 to f6aa522 Compare January 13, 2023 23:19
@Pytal Pytal merged commit 72fa249 into master Jan 13, 2023
@Pytal Pytal deleted the enh/a11y-contacts-menu branch January 13, 2023 23:57
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 14, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@artonge artonge Awaiting requested review from artonge

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility feature: contacts menu
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @skjnldsv @ChristophWurst @szaimen