Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CSS hover behavior on quota information #35625

Closed
wants to merge 5 commits into from

Conversation

Jerome-Herbinet
Copy link
Member

@Jerome-Herbinet Jerome-Herbinet commented Dec 6, 2022

Signed-off-by: Jérôme Herbinet 33763786+Jerome-Herbinet@users.noreply.github.com

Signed-off-by: Jérôme Herbinet 33763786+Jerome-Herbinet@users.noreply.github.com

Disable CSS hover behavior on quota information (because it's not a button)

2022-12-06_16-35

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@szaimen
Copy link
Contributor

szaimen commented Dec 6, 2022

Thanks for your PR! Please do your changes on this file: https://github.com/nextcloud/server/blob/master/core/css/apps.scss and run npm run sass and commit the changed css files. Thank you! :)

@szaimen szaimen added the 2. developing Work in progress label Dec 6, 2022
@szaimen szaimen added this to the Nextcloud 26 milestone Dec 6, 2022
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@Jerome-Herbinet
Copy link
Member Author

Thanks for your PR! Please do your changes on this file: https://github.com/nextcloud/server/blob/master/core/css/apps.scss and run npm run sass and commit the changed css files. Thank you! :)

You're welcome :-)
I didn't have time to do it yesterday. It's done now.
Have nice day !

@Jerome-Herbinet
Copy link
Member Author

Some errors are remaining ; do you know what could be going on ?

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@Jerome-Herbinet
Copy link
Member Author

Hi @szaimen,
I manually fixed some conflicts a few days ago. OK for this now.
But, I have now a problem with Drone CI which is failing.
I've been looking at it with @zak39, but we don't understand what this CI problem has to do with what has been done in the modified SCSS file (+ other files generated by npm run sass).
What do you think ?

@blizzz blizzz mentioned this pull request Feb 1, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@szaimen
Copy link
Contributor

szaimen commented Apr 5, 2023

I fear this will need a rebase. Also can you check if this still happens with nc26 since the sidebae was written there afaik

@Jerome-Herbinet
Copy link
Member Author

Jerome-Herbinet commented Apr 5, 2023

Too messy and time-consuming now IMO. I've created a new PR nextcloud-libraries/nextcloud-vue#3958
... in /nextcloud/nextcloud-vue/ (IMO a better way to get what's desired).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants