Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TimedJob from OCP instead of OC #35596

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Dec 5, 2022

While searching for source of #35543 I took the opportunity to move all TimedJob subclasses to using OCP.
Does not fix the bug.

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc self-assigned this Dec 5, 2022
@come-nc come-nc added this to the Nextcloud 26 milestone Dec 5, 2022
$this->config = $config;

$this->setInterval(60 * 60 * 3);
}

protected function run($argument) {
protected function run($argument): void {

Check notice

Code scanning / Psalm

MissingParamType

Parameter $argument has no provided type
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@szaimen szaimen added the 2. developing Work in progress label Dec 5, 2022
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 5, 2022
@come-nc come-nc requested review from CarlSchwan, a team, PVince81 and skjnldsv and removed request for a team December 5, 2022 13:13
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@come-nc come-nc merged commit 1821712 into master Dec 6, 2022
@come-nc come-nc deleted the fix/move-to-ocp-timedjob branch December 6, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants