Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] Revert "[stable25] Fix border color contrast" #35454

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Nov 28, 2022

Workaround for #35457 to not block 25.0.2

Signed-off-by: Simon L szaimen@e.mail.de

Before After
image image
image image

Tested with:

docker run -it \
--name nextcloud-easy-test \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.24.128 \
-e SERVER_BRANCH=revert-35346-backport/35315/stable25 \
-e CALENDAR_BRANCH=main \
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" \
ghcr.io/szaimen/nextcloud-easy-test:latest

Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen added 2. developing Work in progress 3. to review Waiting for reviews high and removed 2. developing Work in progress labels Nov 28, 2022
@szaimen szaimen added this to the Nextcloud 25.0.2 milestone Nov 28, 2022
@szaimen szaimen requested review from Pytal, skjnldsv, jancborchardt, nimishavijay, JuliaKirschenheuter, ChristophWurst, a team and PVince81 and removed request for a team November 28, 2022 10:38
@szaimen szaimen marked this pull request as ready for review November 28, 2022 10:39
@szaimen szaimen changed the title Revert "[stable25] Fix border color contrast" [stable25] Revert "[stable25] Fix border color contrast" Nov 28, 2022
@ChristophWurst
Copy link
Member

Mind adding a reason for the revert?

@szaimen
Copy link
Contributor Author

szaimen commented Nov 28, 2022

Mind adding a reason for the revert?

See the disscussion in the engineering chat.

@PVince81
Copy link
Member

the chat is not available for the public

the reason is: 25.0.2 RC1 is out and causes a regression in some apps.
since we plan to release final this week, the quickest way to solve the regression is to revert for now, for 25.0.2, and then work on the proper fix (not rushed) after 25.0.2 is out.

I'll leave this PR open until we get the feedback from @Pytal later today, if the proper fix is indeed not trivial

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 as discussed

up to @Pytal to merge it

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me if a revert is needed quickly. After that an ideal fix would be with an extra variable as said in the issue. :)

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 28, 2022
@Pytal Pytal merged commit 233ae5a into stable25 Nov 28, 2022
@Pytal Pytal deleted the revert-35346-backport/35315/stable25 branch November 28, 2022 17:54
@Pytal
Copy link
Member

Pytal commented Nov 28, 2022

Discussion with design team and accessibility reviewer will be tracked in #35457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants