New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting default location for weather widget #35270

Closed

Mazhoon wants to merge 2 commits into nextcloud:master from Mazhoon:patch-1

Mazhoon commented Nov 18, 2022

In cases where all of the users are from the same geographical area, it would be extremely useful to be able to set a default location for the dashboard weather widget. With these changes, this option becomes available, as default values can be set with occ config:app:set weather_status [lat,lon,altitude,address] --value 'value'

These changes also implement the path 2 described in feature request #27908 denied in 2021

Signed-off-by: Tuomas Nurmi tuomas.nurmi@opinsys.fi

szaimen added enhancement 3. to review labels

szaimen added this to the Nextcloud 26 milestone

szaimen requested review from a team, icewind1991, blizzz and come-nc and removed request for a team

November 18, 2022 23:42

come-nc reviewed

View reviewed changes

Contributor

come-nc left a comment

No strong opinion about this

apps/weather_status/lib/Service/WeatherStatusService.php Outdated Show resolved Hide resolved

Member

PVince81 commented Dec 16, 2022

@jancborchardt thoughts on this ? note: this requires occ commands to set the values, there's no UI

blizzz mentioned this pull request

26.0.0 beta 2 #36484

Merged

skjnldsv mentioned this pull request

26.0.0 beta 5 #36834

Merged

blizzz mentioned this pull request

26.0.0 RC2 #37078

Merged

blizzz modified the milestones: Nextcloud 26, Nextcloud 27

This was referenced May 3, 2023

27.0.0 beta 1 #38038

Merged

27.0.0 beta 2 #38137

Closed

27.0.0 beta 2 #38139

Merged

blizzz mentioned this pull request

27.0.0 RC1 #38341

Merged

blizzz modified the milestones: Nextcloud 27, Nextcloud 28

skjnldsv mentioned this pull request

chore: 28.0.0 beta 1 #41228

Merged

This was referenced Nov 6, 2023

28.0.0 beta 2 #41314

Merged

28.0.0 beta 3 #41379

Merged

This was referenced Nov 14, 2023

28.0.0 beta 4 #41477

Merged

28.0.0 RC1 #41621

Merged

blizzz modified the milestones: Nextcloud 28, Nextcloud 29

Mazhoon and others added 2 commits

February 27, 2024 14:16


          Allow setting default location for weather widget

b17cd50

In cases where all of the users are from the same geographical area, it would be extremely useful to be able to set a default location for the dashboard weather widget. With these changes, this option becomes available, as default values can be set with
occ config:app:set weather_status [lat,lon,altitude,address] --value 'value'

These changes also implement the path 2 described in feature request nextcloud#27908 denied in 2021

Signed-off-by: Tuomas Nurmi <tuomas.nurmi@opinsys.fi>


          Fix typo in weather default location setting.

357f073

Was 'lat' instead of 'lon', thanks for catching!

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Tuomas Nurmi <tuomas.nurmi@opinsys.fi>

AndyScherzinger force-pushed the patch-1 branch from e2b75a0 to 357f073 Compare

February 27, 2024 13:16

github-advanced-security bot found potential problems

View reviewed changes

apps/weather_status/lib/Service/WeatherStatusService.php

-              		$lat = $this->config->getUserValue($this->userId, Application::APP_ID, 'lat', '');
-              		$lon = $this->config->getUserValue($this->userId, Application::APP_ID, 'lon', '');
-              		$address = $this->config->getUserValue($this->userId, Application::APP_ID, 'address', '');
+                      $lat = $this->config->getUserValue($this->userId, Application::APP_ID, 'lat', $this->config->getAppValue(Application::APP_ID, 'lat', ''));

Check notice

Code scanning / Psalm

DeprecatedMethod Note

The method OCP\IConfig::getAppValue has been marked as deprecated

apps/weather_status/lib/Service/WeatherStatusService.php

-              		$lon = $this->config->getUserValue($this->userId, Application::APP_ID, 'lon', '');
-              		$address = $this->config->getUserValue($this->userId, Application::APP_ID, 'address', '');
+                      $lat = $this->config->getUserValue($this->userId, Application::APP_ID, 'lat', $this->config->getAppValue(Application::APP_ID, 'lat', ''));
+                      $lon = $this->config->getUserValue($this->userId, Application::APP_ID, 'lon', $this->config->getAppValue(Application::APP_ID, 'lon', ''));

Check notice

Code scanning / Psalm

DeprecatedMethod Note

The method OCP\IConfig::getAppValue has been marked as deprecated

apps/weather_status/lib/Service/WeatherStatusService.php

    
              		$address = $this->config->getUserValue($this->userId, Application::APP_ID, 'address', '');

                      $lat = $this->config->getUserValue($this->userId, Application::APP_ID, 'lat', $this->config->getAppValue(Application::APP_ID, 'lat', ''));

                      $lon = $this->config->getUserValue($this->userId, Application::APP_ID, 'lon', $this->config->getAppValue(Application::APP_ID, 'lon', ''));

                      $address = $this->config->getUserValue($this->userId, Application::APP_ID, 'address', $this->config->getAppValue(Application::APP_ID, 'address', ''));

Check notice

Code scanning / Psalm

DeprecatedMethod Note

The method OCP\IConfig::getAppValue has been marked as deprecated

apps/weather_status/lib/Service/WeatherStatusService.php

-              		$lat = $this->config->getUserValue($this->userId, Application::APP_ID, 'lat', '');
-              		$lon = $this->config->getUserValue($this->userId, Application::APP_ID, 'lon', '');
-              		$alt = $this->config->getUserValue($this->userId, Application::APP_ID, 'altitude', '');
+                      $lat = $this->config->getUserValue($this->userId, Application::APP_ID, 'lat', $this->config->getAppValue(Application::APP_ID, 'lat', ''));

Check notice

Code scanning / Psalm

DeprecatedMethod Note

The method OCP\IConfig::getAppValue has been marked as deprecated

apps/weather_status/lib/Service/WeatherStatusService.php

-              		$lon = $this->config->getUserValue($this->userId, Application::APP_ID, 'lon', '');
-              		$alt = $this->config->getUserValue($this->userId, Application::APP_ID, 'altitude', '');
+                      $lat = $this->config->getUserValue($this->userId, Application::APP_ID, 'lat', $this->config->getAppValue(Application::APP_ID, 'lat', ''));
+                      $lon = $this->config->getUserValue($this->userId, Application::APP_ID, 'lon', $this->config->getAppValue(Application::APP_ID, 'lon', ''));

Check notice

Code scanning / Psalm

DeprecatedMethod Note

The method OCP\IConfig::getAppValue has been marked as deprecated

apps/weather_status/lib/Service/WeatherStatusService.php

    
              		$alt = $this->config->getUserValue($this->userId, Application::APP_ID, 'altitude', '');

                      $lat = $this->config->getUserValue($this->userId, Application::APP_ID, 'lat', $this->config->getAppValue(Application::APP_ID, 'lat', ''));

                      $lon = $this->config->getUserValue($this->userId, Application::APP_ID, 'lon', $this->config->getAppValue(Application::APP_ID, 'lon', ''));

                      $alt = $this->config->getUserValue($this->userId, Application::APP_ID, 'altitude', $this->config->getAppValue(Application::APP_ID, 'altitude', ''));

Check notice

Code scanning / Psalm

DeprecatedMethod Note

The method OCP\IConfig::getAppValue has been marked as deprecated

This was referenced Mar 12, 2024

29.0.0 beta 2 #44152

Merged

29.0.0 beta 3 #44186

Merged

29.0.0 beta 4 #44275

Merged

This was referenced Mar 20, 2024

29.0.0 beta 5 #44361

Merged

29.0.0 beta 6 #44449

Merged

skjnldsv mentioned this pull request

29.0.0 RC1 #44552

Merged

81 tasks

skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30

skjnldsv added 2. developing stale and removed 3. to review labels

This was referenced Jul 30, 2024

30.0.0 beta 2 #46870

Merged

30.0.0 beta 3 #46946

Merged

This was referenced Aug 5, 2024

30.0.0 beta 4 #47028

Merged

30.0.0 beta 5 #47100

Merged

skjnldsv mentioned this pull request

30.0.0 RC1 #47190

Merged

skjnldsv closed this

skjnldsv removed this from the Nextcloud 30 milestone

This comment was marked as outdated.

Sign in to view

Member

skjnldsv commented Aug 16, 2024

@jancborchardt thoughts on this ? note: this requires occ commands to set the values, there's no UI

@jancborchardt Can you reply to this?

Regarding the closure, this doesn't mean this is a bad idea, we're just cleaing old stale PR.
(though my comment came late because yesterday was public holiday, sorry for the confusion @Mazhoon 🌞)
That doesn't mean we do not want that feature, but it seems incomplete for now.

Member

skjnldsv commented Aug 16, 2024

If we want to stay code-only, (there isn't really an admin settings UI location), we could have this as a config option like the default timezone 🤔

server/config/config.sample.php

Line 269 in 2ea6713

'default_timezone' => 'Europe/Berlin',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing enhancement stale