Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] delay updating setup providers untill we register the mounts #35258

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #35218

otherwise the fallback to a full setup for a missing cached mount provider will lead to a race condition

Signed-off-by: Robin Appelman <robin@icewind.nl>
@szaimen szaimen added bug 3. to review Waiting for reviews labels Nov 18, 2022
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 18, 2022
@szaimen szaimen merged commit d9ad303 into stable24 Nov 18, 2022
@szaimen szaimen deleted the backport/35218/stable24 branch November 18, 2022 16:42
@blizzz blizzz mentioned this pull request Nov 21, 2022
9 tasks
@r-hmn
Copy link

r-hmn commented Nov 29, 2022

Question(don't know where to ask otherwise)
Will this be in the upcoming https://github.com/nextcloud/all-in-one/releases/tag/v3.1.0 ?
Otherwise share's function in AIO is still broken and thus unusable.

@szaimen
Copy link
Contributor

szaimen commented Nov 29, 2022

Question(don't know where to ask otherwise) Will this be in the upcoming https://github.com/nextcloud/all-in-one/releases/tag/v3.1.0 ? Otherwise share's function in AIO is still broken and thus unusable.

Hi, see nextcloud/all-in-one#1434 (comment)

@r-hmn
Copy link

r-hmn commented Nov 29, 2022

Hi, thanks. i did execute that and it works.
ok, good that i have confirmation of you that i can use this patch on v3.1.0 also 👍
(ps. i've upgraded my old macbook by the way, now running decent hardware ;) )

@szaimen
Copy link
Contributor

szaimen commented Nov 29, 2022

Hi, thanks. i did execute that and it works. ok, good that i have confirmation of you that i can use this patch on v3.1.0 also 👍 (ps. i've upgraded my old macbook by the way, now running decent hardware ;) )

It is unfortunately already too late for that. The fix will be included in the version after 3.1.0.

@r-hmn
Copy link

r-hmn commented Nov 29, 2022

yes, i see. no worries. at least i can patch it with the same patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants