Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#34969 Fix AppMenu icons for firefox #34971

Closed
wants to merge 1 commit into from
Closed

#34969 Fix AppMenu icons for firefox #34971

wants to merge 1 commit into from

Conversation

cupcakearmy
Copy link

@szaimen szaimen requested review from juliushaertl, a team, PVince81, artonge and Pytal and removed request for a team November 4, 2022 15:14
@szaimen szaimen added this to the Nextcloud 26 milestone Nov 4, 2022
@cupcakearmy
Copy link
Author

@szaimen thanks for looking at this :) Is there any way this could land in 25 and not 26? it's quite a critical visual bug for anyone using firefox, as the icons on the homescreen simply stop showing up :)

@szaimen szaimen added the 3. to review Waiting for reviews label Nov 7, 2022
@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2022

@cupcakearmy it will make it for 26 first, then backported to 25

@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2022

/backport to stable25

@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2022

Can you rebase, compile and ship the compiled dist files too @cupcakearmy please? :)

@cupcakearmy
Copy link
Author

@skjnldsv I see :) perfect!

Rebase on what? I'm not a huge rebase expert xD

@cupcakearmy
Copy link
Author

I tried installing the deps in the github codespaces (don't want to install it locally) but for some reason I get errors when running make dev-setup (to rebuild the dist file)

Error while executing:
npm ERR! /usr/bin/git ls-remote -h -t ssh://git@github.com/nextcloud/strengthify.git

Otherwise running npm i leaves ~25 peer deps uninstalled and the build fails.

I don't have time to go down this rabbit hole unfortunately. Feel free to use the code at free will.

@szaimen
Copy link
Contributor

szaimen commented Nov 8, 2022

Thanks for the PR! I've taken over and pushed the fix to #35029

@szaimen szaimen closed this Nov 8, 2022
@cupcakearmy
Copy link
Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Icons in the AppMenu not showing properly in Firefox
3 participants