Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] Update @nextcloud/dialogs and fix toasts styling #34928

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Nov 2, 2022

  • ⚠️ This backport had conflicts and is incomplete

backport of #34868

@skjnldsv
Copy link
Member

skjnldsv commented Nov 2, 2022

/compile amend /

@blizzz blizzz mentioned this pull request Nov 2, 2022
@PVince81

This comment was marked as resolved.

@blizzz blizzz mentioned this pull request Nov 21, 2022
1 task
@blizzz blizzz assigned blizzz and skjnldsv and unassigned blizzz Nov 21, 2022
@blizzz blizzz added the 2. developing Work in progress label Nov 21, 2022
@blizzz

This comment was marked as resolved.

@szaimen

This comment was marked as resolved.

@szaimen

This comment was marked as resolved.

@szaimen

This comment was marked as resolved.

@skjnldsv
Copy link
Member

Rebased and compiled

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 22, 2022
@szaimen
Copy link
Contributor

szaimen commented Nov 22, 2022

One approval missing...

@skjnldsv
Copy link
Member

/compile amend /

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen
Copy link
Contributor

szaimen commented Nov 23, 2022

Seems like some tests are still pending?

@szaimen
Copy link
Contributor

szaimen commented Nov 23, 2022

Shall we still merge?

@skjnldsv skjnldsv merged commit 5cd1e77 into stable25 Nov 23, 2022
@skjnldsv skjnldsv deleted the backport/34868/stable25 branch November 23, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants