Dispatch event for all removed entries

[artonge]

When removing a folder, dispatch the event for all the deleted entries and not only for the folder.

Does it make sense, or was the old behavior on purpose ?

[juliushaertl]

Sounds like something we should have, I'd just be cautious about possible performance impact on large folder deletion. Did you attempt to fix a specific case with this?

[artonge]

Sounds like something we should have, I'd just be cautious about possible performance impact on large folder deletion. Did you attempt to fix a specific case with this?

Performance wise, I think that the change simply move the iteration work from the listener to the dispatcher. Meaning, when a folder is deleted, instead of having to look for children in every listener, we do it once on the dispatcher side.

So we are comparing the load of emitting more events to the load of listing directories multiple times.

I think it also makes more sense regarding the naming of the event. If you listen to CacheEntryRemovedEvent you expect to receive the event for every entry, no ? So without this change, you miss on a lot of entry deletion.

I two specific cases:

1. In photos, where we delete file entries from albums when they are deleted:
   https://github.com/nextcloud/photos/blob/f034ce6517b0c523dacce17d976da0945c5cdb7e/lib/Listener/CacheEntryRemovedListener.php
2. And this PR in server that improves how we manage metadata with events:
   Listen to cache event for managing metadata #34586

[artonge]

Ping for review :)

[PVince81]

I'd like to know what @icewind1991 thinks

I vaguely remember that some events are purposefully only triggered on the container and not on all children, for performance reasons

[juliushaertl]

🏓 @icewind1991 for some input

[artonge]

/rebase

[icewind1991]

Not the best in case of performance but probably better than the alternatives that can be done easily

[marcelklehr]

This is kinda a breaking change. Should be added here: #37039