Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix encryption wrapper filesize for non existing files #34607

Merged
merged 1 commit into from
Apr 6, 2023
Merged

fix encryption wrapper filesize for non existing files #34607

merged 1 commit into from
Apr 6, 2023

Conversation

icewind1991
Copy link
Member

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Oct 14, 2022
@icewind1991 icewind1991 requested review from a team, PVince81, CarlSchwan and come-nc and removed request for a team October 14, 2022 12:51
PVince81
PVince81 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 modified the milestones: Nextcloud 25, Nextcloud 26 Oct 14, 2022
@PVince81
Copy link
Member

/rebase

@nextcloud-command nextcloud-command force-pushed the encryption-size-not-found branch from 9f4375c to fb5ff8f Compare October 21, 2022 13:39
@PVince81 PVince81 requested a review from artonge December 16, 2022 16:48
artonge
artonge reviewed Dec 19, 2022
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we throw a OCP\Files\NotFoundException ?

@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
come-nc
come-nc requested changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should return false instead, since this is what is returned when filesize fails on local storage.

@icewind1991
fix encryption wrapper filesize for non existing files
15a6920 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the encryption-size-not-found branch from fb5ff8f to 15a6920 Compare April 4, 2023 14:21
@icewind1991
Copy link
Member Author

I think it should return false instead, since this is what is returned when filesize fails on local storage.

done

@icewind1991 icewind1991 requested a review from come-nc April 4, 2023 15:23
@PVince81 PVince81 merged commit 9f05eff into master Apr 6, 2023
@PVince81 PVince81 deleted the encryption-size-not-found branch April 6, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge left review comments

@PVince81 PVince81 PVince81 approved these changes

@come-nc come-nc come-nc approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
5 participants
@icewind1991 @PVince81 @artonge @come-nc @blizzz