Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix navigation pixel flickering #34605

Closed
wants to merge 1 commit into from
Closed

Fix navigation pixel flickering #34605

wants to merge 1 commit into from

Conversation

skjnldsv
Copy link
Member

fix #34591

Margin is not included in the hovering.

@skjnldsv skjnldsv added 3. to review Waiting for reviews accessibility labels Oct 14, 2022
@skjnldsv skjnldsv added this to the Nextcloud 26 milestone Oct 14, 2022
@skjnldsv skjnldsv requested review from nickvergessen, juliusknorr and a team October 14, 2022 12:36
@skjnldsv skjnldsv self-assigned this Oct 14, 2022
@skjnldsv skjnldsv requested review from PVince81, artonge and szaimen and removed request for a team October 14, 2022 12:36
@skjnldsv skjnldsv added the bug label Oct 14, 2022
@skjnldsv
Copy link
Member Author

/backport to stable25

szaimen
szaimen approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@skjnldsv
Copy link
Member Author

/rebase

szaimen
szaimen requested changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just tested this and doesnt seem to resolve the issue competely:

2022-10-18-202058.mp4

@nickvergessen

This comment was marked as resolved.

Sign in to view
@szaimen

This comment was marked as resolved.

Sign in to view
@szaimen

This comment was marked as resolved.

Sign in to view
@skjnldsv
Copy link
Member Author

Can you try again @szaimen ?

@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv requested a review from szaimen October 26, 2022 15:47
@skjnldsv
Fix navigation pixel flickering
484d101 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@szaimen
Copy link
Contributor

szaimen commented Oct 26, 2022

I can still reproduce this issue with this branch. Just tried again.

@szaimen
Copy link
Contributor

szaimen commented Oct 26, 2022 •
edited by skjnldsv
Loading

This is my test instance and even tried in a new incognito tab and session.

docker run -it \
	--name nextcloud-easy-test \
	-p 127.0.0.1:8443:443 \
	-e SERVER_BRANCH=fix/navigation-flicker \
	-e COMPILE_SERVER=1 \
	--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" \
	ghcr.io/szaimen/nextcloud-easy-test:latest

@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@skjnldsv skjnldsv mentioned this pull request May 3, 2023
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 27, Nextcloud 28 May 3, 2023
@skjnldsv skjnldsv closed this Sep 2, 2023
@szaimen szaimen deleted the fix/navigation-flicker branch September 2, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@PVince81 PVince81 Awaiting requested review from PVince81

@artonge artonge Awaiting requested review from artonge

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews accessibility bug
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

Flickering header menu
5 participants
@skjnldsv @nickvergessen @szaimen @juliusknorr @blizzz