Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix iMigration type hints #34562

Closed
wants to merge 1 commit into from
Closed

fix iMigration type hints #34562

wants to merge 1 commit into from

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Oct 12, 2022

No description provided.

miaulalala
miaulalala approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Roeland, I just ran into this

@rullzer
Copy link
Member Author

rullzer commented Oct 28, 2022

Thanks Roeland, I just ran into this

well it still does boom it seems.
But feel free ot have a look and push potential fixes ;)

@skjnldsv skjnldsv added this to the Nextcloud 26 milestone Oct 28, 2022
@miaulalala miaulalala force-pushed the fix-migration-closures branch from bc1c06b to 67d0da1 Compare October 28, 2022 11:25
@miaulalala miaulalala requested a review from skjnldsv October 28, 2022 11:39
@miaulalala miaulalala self-assigned this Oct 28, 2022
@miaulalala miaulalala added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 28, 2022
@miaulalala miaulalala changed the title fix imigration type hints fix iMigration type hints Nov 4, 2022
@ChristophWurst
Copy link
Member

I traced the same error and reported the quirk to Psalm: vimeo/psalm#8846. SimpleMigrationStep widens the Closure type narrowed by IMigrationStep.

@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@rullzer @miaulalala
fix imigration type hints
65897d2 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@miaulalala miaulalala force-pushed the fix-migration-closures branch from acf9c4a to 65897d2 Compare February 20, 2023 11:14
@miaulalala
Copy link
Contributor

@rullzer feel free to continue but I'm out, this breaks all apps unfortunately

@miaulalala miaulalala removed their assignment Feb 20, 2023
@ChristophWurst ChristophWurst added 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 3. to review Waiting for reviews labels Feb 20, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@skjnldsv skjnldsv mentioned this pull request May 3, 2023
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 27, Nextcloud 28 May 9, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv skjnldsv added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Feb 21, 2024
This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
This was referenced Jul 30, 2024
Merged
Merged
This was referenced Aug 5, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 13, 2024
@skjnldsv skjnldsv added the stale Ticket or PR with no recent activity label Aug 13, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 31 milestone Aug 13, 2024
@skjnldsv skjnldsv closed this Aug 13, 2024
@skjnldsv skjnldsv deleted the fix-migration-closures branch August 13, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala requested changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
2. developing Work in progress bug stale Ticket or PR with no recent activity technical debt
Projects
💌 📅 👥 Groupware team
Status: ☑️ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rullzer @ChristophWurst @miaulalala @blizzz @skjnldsv