Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Fix invisible status #34335

Merged
merged 2 commits into from
Sep 30, 2022
Merged

[stable25] Fix invisible status #34335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
467a0ea
Fix invisible status
skjnldsv Sep 29, 2022
885b55b
Compile assets
nextcloud-command Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/user_status/css/user-status-menu.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/user_status/css/user-status-menu.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions apps/user_status/css/user-status-menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
background-image: url('../img/user-status-dnd.svg');
}

// TODO: debug why icon-black-white does not work here
.icon-user-status-invisible {
@include icon-color('user-status-invisible', 'user_status', variables.$color-black, 1);
background-image: url('../img/user-status-invisible.svg');
filter: var(--background-invert-if-dark);
}
14 changes: 13 additions & 1 deletion apps/user_status/src/components/OnlineStatusSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@
type="radio"
name="user-status-online"
@change="onChange">
<label :for="id" :class="icon" class="user-status-online-select__label">
<label :for="id" class="user-status-online-select__label">
{{ label }}
<span :class="icon" role="img" />
<em class="user-status-online-select__subline">{{ subline }}</em>
</label>
</div>
Expand Down Expand Up @@ -76,6 +77,7 @@ export default {
</script>

<style lang="scss" scoped>
@use 'sass:math';
$icon-size: 24px;
$label-padding: 8px;

Expand All @@ -91,6 +93,7 @@ $label-padding: 8px;
}

&__label {
position: relative;
display: block;
margin: $label-padding;
padding: $label-padding;
Expand All @@ -105,6 +108,15 @@ $label-padding: 8px;
& {
cursor: pointer;
}

span {
position: absolute;
top: calc(50% - math.div($icon-size, 2));
left: $label-padding;
display: block;
width: $icon-size;
height: $icon-size;
}
}

&__input:checked + &__label,
Expand Down
4 changes: 2 additions & 2 deletions dist/user-status-modal-8299.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/user-status-modal-8299.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/user_status-menu.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/user_status-menu.js.map
View file
Open in desktop

Large diffs are not rendered by default.