Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Url encode the web dav url for copying #34289

Merged
merged 1 commit into from
Oct 2, 2022
Merged

Url encode the web dav url for copying #34289

merged 1 commit into from
Oct 2, 2022

Conversation

miaulalala
Copy link
Contributor

No description provided.

@miaulalala miaulalala self-assigned this Sep 27, 2022
@miaulalala
Copy link
Contributor Author

/backport to stable25

@miaulalala
Copy link
Contributor Author

/backport to stable24

@miaulalala
Copy link
Contributor Author

/backport to stable23

@miaulalala
Copy link
Contributor Author

/backport to stable22

szaimen
szaimen reviewed Sep 27, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also a test would be good, I guess

szaimen
szaimen reviewed Sep 27, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miaulalala can you add a teste for this?

PVince81
PVince81 approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

@miaulalala please squash

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 28, 2022
@blizzz blizzz added this to the Nextcloud 26 milestone Oct 1, 2022
@miaulalala
Copy link
Contributor Author

/rebase

@miaulalala
Url encode the web dav url for copying
25409cb 
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala merged commit 663751c into master Oct 2, 2022
@miaulalala miaulalala deleted the fix/url-encode-webdav-url branch October 2, 2022 12:28
This was referenced Oct 2, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen left review comments

@nickvergessen nickvergessen nickvergessen approved these changes

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@miaulalala miaulalala

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: dav
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
6 participants
@miaulalala @PVince81 @nickvergessen @skjnldsv @szaimen @blizzz