Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User list : User name and Display name visibility improvement #34163

Merged
merged 7 commits into from
Sep 26, 2022
Merged

User list : User name and Display name visibility improvement #34163

merged 7 commits into from
Sep 26, 2022

Conversation

Jerome-Herbinet
Copy link
Member

Signed-off-by: Jérôme Herbinet jerome.herbinet@arawa.fr

Signed-off-by: Jérôme Herbinet 33763786+Jerome-Herbinet@users.noreply.github.com

@Jerome-Herbinet
Copy link
Member Author

Jerome-Herbinet commented Sep 20, 2022 •
edited
Loading

@szaimen (following our conversation a few minutes ago) I've closed my old messy PR (#33669) and I've created this brand new one, with exactly the same changes. It of course takes in account the design feedback of @jancborchardt. I think that everything should be OK (hoping it's not too late for Nextcloud 25).

@Jerome-Herbinet Jerome-Herbinet mentioned this pull request Sep 20, 2022
Closed
@szaimen
Copy link
Contributor

szaimen commented Sep 20, 2022

@szaimen (following our conversation a few minutes ago) I've closed my old messy PR (#33669) and I've created this brand new one, with exactly the same changes. It of course takes in account the design feedback of @jancborchardt. I think that everything should be OK (hoping it's not too late for Nextcloud 25).

Thank you! Yes, the PR looks good to me. However I fear we need the compiled js. Can you please run npm run build and commit the changes to this branch?

@szaimen szaimen added the 3. to review Waiting for reviews label Sep 20, 2022
@szaimen szaimen added this to the Nextcloud 25 milestone Sep 20, 2022
@szaimen szaimen requested review from Pytal, GretaD and szaimen September 20, 2022 14:17
@Jerome-Herbinet
Copy link
Member Author

@szaimen (following our conversation a few minutes ago) I've closed my old messy PR (#33669) and I've created this brand new one, with exactly the same changes. It of course takes in account the design feedback of @jancborchardt. I think that everything should be OK (hoping it's not too late for Nextcloud 25).

Thank you! Yes, the PR looks good to me. However I fear we need the compiled js. Can you please run npm run build and commit the changes to this branch?

OK @szaimen, it's done.

@szaimen
Copy link
Contributor

szaimen commented Sep 21, 2022

OK @szaimen, it's done.

Thanks! However a npm run sass and commiting the changed files is unfortunately needed as well. Afterwarsa the node test should be green.

@Jerome-Herbinet
Copy link
Member Author

OK @szaimen, it's done.

OK @szaimen, it's done for this as well :-)

@blizzz blizzz mentioned this pull request Sep 22, 2022
Merged
2 tasks
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@Jerome-Herbinet
User list : Display name CSS change
6c081bd 
Signed-off-by: Jérôme Herbinet jerome.herbinet@arawa.fr

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@Jerome-Herbinet
User list : Invert user name and display name
1e9fd66 
Signed-off-by: Jérôme Herbinet jerome.herbinet@arawa.fr
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@Jerome-Herbinet
User list : Other user and display name inversion
f233077 
Signed-off-by: Jérôme Herbinet jerome.herbinet@arawa.fr
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@Jerome-Herbinet
build front-end
f2ca65b 
Signed-off-by: Jérôme Herbinet jerome.herbinet@arawa.fr
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@Jerome-Herbinet
build npm run sass
8dd2ea7 
Signed-off-by: Jérôme Herbinet 33763786+Jerome-Herbinet@users.noreply.github.com
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@Jerome-Herbinet
Fix : strong HTML end tag
9e4fe9d 
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@Jerome-Herbinet
Fix : strong end tag
e393e13 
<33763786+Jerome-Herbinet@users.noreply.github.com>

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@szaimen
Copy link
Contributor

szaimen commented Sep 23, 2022

Thanks! I'll review and test it out later on!

@szaimen
Copy link
Contributor

szaimen commented Sep 26, 2022

This is how it looks now:
image

szaimen
szaimen approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szaimen szaimen requested a review from a team September 26, 2022 12:01
@szaimen szaimen requested review from artonge and removed request for a team September 26, 2022 12:01
@Pytal Pytal requested a review from nimishavijay September 26, 2022 17:13
nimishavijay
nimishavijay approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :)

@szaimen
Copy link
Contributor

szaimen commented Sep 26, 2022

CI failure unrelated

@szaimen szaimen merged commit 7a701f2 into nextcloud:master Sep 26, 2022
@szaimen
Copy link
Contributor

szaimen commented Sep 26, 2022

Thanks for you patience and effort @Jerome-Herbinet !

@Jerome-Herbinet Jerome-Herbinet deleted the patch-6 branch August 29, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimishavijay nimishavijay nimishavijay approved these changes

@szaimen szaimen szaimen approved these changes

@Pytal Pytal Pytal approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
5 participants
@Jerome-Herbinet @szaimen @Pytal @nimishavijay @blizzz