Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contactsmenu design #33967

Merged
merged 4 commits into from
Sep 9, 2022
Merged

Fix contactsmenu design #33967

merged 4 commits into from
Sep 9, 2022

Conversation

jancborchardt
Copy link
Member

  • Set email addresses in maxcontrast color so they are not so present
  • Remove the divider lines as they do not fit our style anymore and they are not needed for narrow lists like these
  • Adjust the height so a half entry is cut off, so people immediately see that there are more entries in the list and it’s scrollable
Before After
image image

Further issues tracked there, also cc @karlitschek as discussed:

@jancborchardt jancborchardt added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: contacts menu labels Sep 8, 2022
@jancborchardt jancborchardt added this to the Nextcloud 25 milestone Sep 8, 2022
CarlSchwan
CarlSchwan approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from the fact that this needs to be done in the scss file

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 8, 2022
@blizzz blizzz mentioned this pull request Sep 8, 2022
Merged
szaimen
szaimen requested changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address Carl's comment

@CarlSchwan CarlSchwan requested a review from szaimen September 8, 2022 16:23
jancborchardt and others added 4 commits September 8, 2022 18:24
@jancborchardt @CarlSchwan
Contacts menu mail addresses in maxcontrast
1ade91a 
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
@jancborchardt @CarlSchwan
Contacts menu height adjustment so it shows 4.5 entries
b0392f4 
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
@jancborchardt @CarlSchwan
Remove separation borders from contacts menu entries
43616a7 
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
@CarlSchwan
Port css to scss
af30e7f 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan force-pushed the fix/contactsmenu-design branch from 0082d8e to af30e7f Compare September 8, 2022 16:24
@CarlSchwan CarlSchwan enabled auto-merge September 8, 2022 16:24
@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Sep 8, 2022
@CarlSchwan CarlSchwan disabled auto-merge September 9, 2022 06:43
@CarlSchwan CarlSchwan merged commit 0148ec3 into master Sep 9, 2022
@CarlSchwan CarlSchwan deleted the fix/contactsmenu-design branch September 9, 2022 06:44
@blizzz blizzz mentioned this pull request Sep 9, 2022
Merged
This was referenced Sep 12, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@szaimen szaimen szaimen approved these changes

@nimishavijay nimishavijay nimishavijay approved these changes

@quentinguidee quentinguidee Awaiting requested review from quentinguidee

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: contacts menu
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
4 participants
@jancborchardt @CarlSchwan @szaimen @nimishavijay