Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix versions icons #33958

Merged
merged 1 commit into from
Sep 9, 2022
Merged

fix versions icons #33958

merged 1 commit into from
Sep 9, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Sep 8, 2022

Close #33860

Before After
image image

Signed-off-by: szaimen szaimen@e.mail.de

@szaimen szaimen added the 2. developing Work in progress label Sep 8, 2022
@szaimen szaimen added this to the Nextcloud 25 milestone Sep 8, 2022
@szaimen szaimen force-pushed the enh/33860/fix-versions-visibility branch 2 times, most recently from 2a61cf5 to 16af0ae Compare September 8, 2022 09:05
@szaimen
Copy link
Contributor Author

szaimen commented Sep 8, 2022

/compile amend /

@nextcloud-command nextcloud-command force-pushed the enh/33860/fix-versions-visibility branch from 16af0ae to 98bc61e Compare September 8, 2022 11:02
@blizzz blizzz mentioned this pull request Sep 8, 2022
@szaimen szaimen force-pushed the enh/33860/fix-versions-visibility branch from 98bc61e to 86d552b Compare September 8, 2022 12:16
@szaimen
Copy link
Contributor Author

szaimen commented Sep 8, 2022

/compile amend /

@nextcloud-command nextcloud-command force-pushed the enh/33860/fix-versions-visibility branch from 86d552b to 7a9ed0b Compare September 8, 2022 13:03
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 8, 2022
@szaimen szaimen marked this pull request as ready for review September 8, 2022 13:06
@szaimen szaimen requested review from a team, PVince81, artonge and skjnldsv and removed request for a team September 8, 2022 13:06
@Leptopoda
Copy link
Member

According to the screenshot it looks like the small revert icon on the right is still black.
Couldn't find a separate issue for that so just mentioning it here :)

@szaimen
Copy link
Contributor Author

szaimen commented Sep 9, 2022

According to the screenshot it looks like the small revert icon on the right is still black.
Couldn't find a separate issue for that so just mentioning it here :)

right, didn't see that. will see how to fix that 👍

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 9, 2022
@szaimen szaimen force-pushed the enh/33860/fix-versions-visibility branch from 7a9ed0b to 6a175b1 Compare September 9, 2022 08:43
@szaimen szaimen changed the title fix versions icon fix versions icons Sep 9, 2022
@szaimen
Copy link
Contributor Author

szaimen commented Sep 9, 2022

/compile amend /

Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the enh/33860/fix-versions-visibility branch from 6a175b1 to 0e57fb5 Compare September 9, 2022 09:02
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 9, 2022
@szaimen
Copy link
Contributor Author

szaimen commented Sep 9, 2022

According to the screenshot it looks like the small revert icon on the right is still black.
Couldn't find a separate issue for that so just mentioning it here :)

right, didn't see that. will see how to fix that 👍

fixed

@szaimen szaimen requested review from CarlSchwan and Pytal September 9, 2022 09:08
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshot convinced me

@blizzz blizzz merged commit 76f42e1 into master Sep 9, 2022
@blizzz blizzz deleted the enh/33860/fix-versions-visibility branch September 9, 2022 11:25
@blizzz blizzz mentioned this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

download button not visible in versions sidebar with dark mode
4 participants