Fix menuitem border radius #33937
Merged
Fix menuitem border radius #33937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
requested review from
a team,
skjnldsv,
Pytal and
szaimen
and removed request for
a team
szaimen
requested changes
Sep 7, 2022
skjnldsv
approved these changes
Sep 7, 2022
|
@CarlSchwan does this also fix the misalignment of the carrot? |
CarlSchwan
force-pushed
the
fix/menuitem-radius
branch
from
ff6acc9 to
8381af3
Compare
no just fix the content to use rounded border like everywhere else |
szaimen
reviewed
Sep 7, 2022
Merged
Fix #33909 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
fix/menuitem-radius
branch
from
8381af3 to
ebd9649
Compare
Can we fix this directly here or shall I do it later? (which would be the double effort imo) |
later |
szaimen
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix part of #33909