fix background shadow in high-contrast-mode #33904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: szaimen <szaimen@e.mail.de>
szaimen
added
3. to review
szaimen
requested review from
skjnldsv,
a team,
PVince81 and
Pytal
and removed request for
a team
szaimen
changed the title
CarlSchwan
approved these changes
Sep 5, 2022
Merged
|
Should it even have shadows? |
Otherwise it will not be separated from the background so no high-contrast anymore... |
skjnldsv
approved these changes
Sep 6, 2022
|
@szaimen what do you think about doing the same think here ?
|
|
This will look strange in the default dark mode. cc @jancborchardt @CarlSchwan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #33833
Signed-off-by: szaimen szaimen@e.mail.de