Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sidebar toggle #33814

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Fix sidebar toggle #33814

merged 1 commit into from
Sep 2, 2022

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 1, 2022

When opening a photo in Photos

Sidebar.vue:464 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'classList')
    at o.setFullScreenMode (Sidebar.vue:464)
    at a.beforeOpen (Viewer.vue:449)
    at Viewer.vue:460
    at u (runtime.js:63)
    at Generator._invoke (runtime.js:294)
    at Generator.next (runtime.js:119)
    at jg (Pencil.vue?12b8:19)
    at a (Pencil.vue?12b8:19)
    at Pencil.vue?12b8:19
    at new Promise (<anonymous>)

@skjnldsv skjnldsv added this to the Nextcloud 25 milestone Sep 1, 2022
@skjnldsv skjnldsv requested review from juliushaertl and a team September 1, 2022 17:18
@skjnldsv skjnldsv self-assigned this Sep 1, 2022
@skjnldsv skjnldsv requested review from PVince81, artonge and Pytal and removed request for a team September 1, 2022 17:18
@skjnldsv skjnldsv mentioned this pull request Sep 1, 2022
Merged
32 tasks
@blizzz blizzz mentioned this pull request Sep 1, 2022
Merged
@juliushaertl
Copy link
Member

/compile amend /

@skjnldsv @nextcloud-command
Fix sidebar toggle
d3e417e 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 2, 2022
@skjnldsv skjnldsv merged commit dbcac39 into master Sep 2, 2022
@skjnldsv skjnldsv deleted the fix-sidebar branch September 2, 2022 14:23
@blizzz blizzz mentioned this pull request Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@Pytal Pytal Pytal approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@artonge artonge Awaiting requested review from artonge

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug ui-refresh-feedback
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
5 participants
@skjnldsv @juliushaertl @CarlSchwan @Pytal @szaimen