Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always use the default fs owner when storing versions #33804

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

icewind1991
Copy link
Member

Alternative to #33305

since hook paths are always relative to the "default filesystem view" we should use that uid for filesystem stuff instead of trying to get the owner for the file.

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Sep 1, 2022
@icewind1991 icewind1991 added this to the Nextcloud 25 milestone Sep 1, 2022
@vinicius73
Copy link
Member

cc @michel-thomas @LinneyS

Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do the trick and makes more sense 👍

This was referenced Sep 1, 2022
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with Julius. Just check the Psalm feedback.

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
Copy link
Member Author

ci should be happy now

@icewind1991 icewind1991 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 6, 2022
@blizzz blizzz merged commit 72aa4f5 into master Sep 6, 2022
@blizzz blizzz deleted the version-store-user branch September 6, 2022 20:30
@julien-nc
Copy link
Member

/backport to stable24

@vinicius73
Copy link
Member

/backport to stable23

@vinicius73
Copy link
Member

/backport to stable22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants