Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composer.lock for integration tests #33714

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Conversation

PVince81
Copy link
Member

Background:

  • for some reason I had a very old local composer.lock from a previous run, and phpunit had the wrong version (6)
  • running composer install would not make it go up to 9 so I kept getting errors when running tests
  • git status did not show that composer.lock was modified because the file is not in git, but also is invisible to git status due to gitignore rules on the "build" folder

So this is a workaround to avoid losing time in the future.
The proper solution is more costy: moving build/integration to test/integration (I wonder if we can symlink those though)

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 self-assigned this Aug 26, 2022
@PVince81 PVince81 added the 3. to review Waiting for reviews label Aug 26, 2022
@PVince81 PVince81 added this to the Nextcloud 25 milestone Aug 26, 2022
@blizzz blizzz merged commit fcc5f1e into master Aug 26, 2022
@blizzz blizzz deleted the techdebt-int-tests-composerlock branch August 26, 2022 10:27
@blizzz blizzz mentioned this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants