Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to load theme/<themename>/dist #33694

Merged
merged 2 commits into from
Aug 28, 2022
Merged

Make it possible to load theme/<themename>/dist #33694

merged 2 commits into from
Aug 28, 2022

Conversation

CarlSchwan
Copy link
Member

This fix a regression with the theming api following the change in
webpack bundling introduced in 24

Signed-off-by: Carl Schwan carl@carlschwan.eu

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Aug 25, 2022
@CarlSchwan CarlSchwan self-assigned this Aug 25, 2022
artonge
artonge approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds right

@CarlSchwan CarlSchwan marked this pull request as draft August 25, 2022 14:37
@CarlSchwan CarlSchwan changed the base branch from stable24 to master August 26, 2022 11:44
@CarlSchwan
Make it possible to load theme/<themename>/dist
de168b3 
This fix a regression with the theming api following the change in
webpack bundling introduced in 24

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan marked this pull request as ready for review August 26, 2022 12:00
@CarlSchwan
Copy link
Member Author

Tested and this is working fine

@CarlSchwan CarlSchwan added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 26, 2022
@CarlSchwan
Merge branch 'master' into fix/load-themedir-dist
e1803a7 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@skjnldsv skjnldsv merged commit ccbeb0f into master Aug 28, 2022
@skjnldsv skjnldsv deleted the fix/load-themedir-dist branch August 28, 2022 07:04
@CarlSchwan
Copy link
Member Author

/backport to stable24

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@blizzz blizzz mentioned this pull request Aug 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees

@CarlSchwan CarlSchwan

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CarlSchwan @artonge @skjnldsv