Fix opening Help page throwing Exception #33682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Commit 458c2fa provoked the error, because the "core" "app" was not found. Previously, false was returned, but now an AppPathNotFoundException - IUrlGenerator::linkTo() accepts an empty app argument however, moving the "core" portion to the path solves it and avoids apps lookup Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
CarlSchwan,
a team,
icewind1991 and
come-nc
and removed request for
a team
blizzz
changed the title
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Pytal
approved these changes
Aug 24, 2022
|
failing tests are unrelated |
come-nc
approved these changes
Aug 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce:
On master, open the "Help" page via drop-down menu on the upper right. You would expect that the page opens, instead you are faced with a server error.
Details:
because the "core" "app" was not found. Previously, false was
returned, but now an AppPathNotFoundException
the "core" portion to the path solves it and avoids apps lookup
This caused one scenarion of user_saml integration tests to fail 😃