Update typehint for confirmDestructive #33670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
force-pushed
the
debt/noid/type-hints-confirm-destructive
branch
from
182dd1f
to
7f27940
Compare
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
debt/noid/type-hints-confirm-destructive
branch
from
7f27940
to
f832db0
Compare
kesselb
requested review from
a team,
PVince81,
Pytal and
szaimen
and removed request for
a team
skjnldsv
approved these changes
Aug 24, 2022
artonge
approved these changes
Aug 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Argument type {confirm: string, cancel: string, type: number, confirmClasses: string} is not assignable to parameter type {type: Int, confirm: String, cancel: String, confirmClasses: String}