Fix primary element color variables #33641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
requested review from
nickvergessen,
CarlSchwan and
skjnldsv
and removed request for
CarlSchwan
GretaD
approved these changes
Aug 22, 2022
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
bugfix/noid/primary-element-vars
branch
from
9703868
to
e85d191
Compare
|
/compile |
skjnldsv
added
4. to release
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
bugfix/noid/primary-element-vars
branch
from
e85d191
to
cc21ea6
Compare
Merged
This was referenced Sep 20, 2022
skjnldsv
reviewed
May 4, 2023
| '--color-primary-element-light' => $colorPrimaryElementLight, | ||
| '--color-primary-element-light-text' => $colorPrimaryElement, | ||
| '--color-primary-element-light-hover' => $this->util->mix($colorPrimaryElementLight, $colorMainText, 90), | ||
| '--color-primary-element-text-dark' => $this->util->darken($this->util->invertTextColor($colorPrimaryElement) ? '#000000' : '#ffffff', 7), |
There was a problem hiding this comment.
Hey @juliushaertl I see you added color-primary-element-text-dark which I cannot find anywhere before.
Was that a mistake? I see only one usage, but I don't think this is actually a necessary variable :)
There was a problem hiding this comment.
I don't remember any use case either. Thinking about it maybe we should also start documenting some context to the variables on when to use?
There was a problem hiding this comment.
That's exactly how I encountered this variable 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have proper variables available to be used with a fallback for very bright colors, this adds the same set of color variables to the theme which based its calculation on the element color.
Required for nextcloud-libraries/nextcloud-vue#3070