-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the loop of calendars when only one is needed #33608
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough for now, but I suggest the following to make psalm happy properly (possibly as an extra PR):
- Add a new interface DirectURIAccess providing the
getCalendarByUri
andgetSubscriptionByUri
. - Implement
getSubscriptionByUri
in CalDAV backend - This allows to do pretty much the same for subscriptions below (more speed ⚡ )
- Put all of this into a
if ($this->caldavBackend instanceof DirectURIAccess)
check so that psalm is happy and we're keeping things clean).
Testing trashbin should work the same btw, through a |
Still some failures in drone |
e8fff40
to
b196f4c
Compare
Drone failures with file sharing acceptance tests (unrelated?) |
Maybe a rebase can tell? |
b196f4c
to
2f0d6f7
Compare
Rebased to (hopefully) fix tests. |
Drone restarted |
2f0d6f7
to
47025d4
Compare
Linter is unhappy |
Signed-off-by: Anna Larch <anna@nextcloud.com>
47025d4
to
3a8c7b6
Compare
Drone failure due to:
|
Fixes #33599