Move findBinaryFinder and isFunctionEnabled away from OC_Helper #33593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
requested review from
ArtificialOwl,
blizzz and
come-nc
and removed request for
a team
CarlSchwan
force-pushed
the
improve-binary-caching
branch
from
b2e9370
to
8b99dbf
Compare
CarlSchwan
force-pushed
the
improve-binary-caching
branch
2 times, most recently
from
9351f1d
to
7669331
Compare
blizzz
approved these changes
Aug 18, 2022
come-nc
requested changes
Aug 22, 2022
CarlSchwan
force-pushed
the
improve-binary-caching
branch
from
a25a7cc
to
27d6950
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CarlSchwan
force-pushed
the
improve-binary-caching
branch
from
27d6950
to
d253787
Compare
ChristophWurst
approved these changes
Aug 23, 2022
come-nc
reviewed
Aug 23, 2022
come-nc
reviewed
Aug 23, 2022
CarlSchwan
force-pushed
the
improve-binary-caching
branch
from
d253787
to
338ea06
Compare
come-nc
approved these changes
Aug 23, 2022
CarlSchwan
force-pushed
the
improve-binary-caching
branch
from
338ea06
to
746a529
Compare
findBinaryFinder is now a service that is still private but with some minor optimization (remove the hasKey check). isFunctionEnabled is now in OCP\Util Both function are still keep but all internal usage in nextcloud/server were migrated to the new usage, so that we can remove it in 26 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
improve-binary-caching
branch
from
746a529
to
9b8ca9a
Compare
nickvergessen
approved these changes
Aug 24, 2022
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findBinaryFinder is now a service that is still private but with some
minor optimization (remove the hasKey check).
isFunctionEnabled is now in OCP\Util
Both functions are still kept but all internal usage in nextcloud/server
were migrated to the new usage, so we can remove it in 26.
Before: 2 redis cache requests either hasKey and get or hasKey and set
Now: 1 redis cache request (get) or 2 redis cache requests (get and set)