Show version from appinfo on occ app:list #33482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
a team,
ArtificialOwl,
icewind1991,
blizzz,
CarlSchwan and
nickvergessen
and removed request for
a team and
blizzz
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
How can there be 2 different versions? Ah, file vs db? |
|
Yes, in case the app has not been upgraded (through enabling or occ upgrade) or if the upgrade may have failed for the app, the installed version from the db still has the old one while the version from app info returns the new one. |
juliusknorr
force-pushed
the
bugfix/app-version-disabled
branch
from
cb8f65f to
c1861db
Compare
|
Yes, legit warning and fixed |
|
While I get the point of returning the same info, the idea was to be able to see the "installed" but disabled version with the occ command. That is also what the Support report shows and is really helpful when people fail to enable apps (because they were actually installed back then but the migration is not working from their old version to the newest one) |
|
Maybe we need to show/add both versions |
Merged
PVince81
added
2. developing
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/app-version-disabled
branch
from
c1861db to
1da6c21
Compare
juliusknorr
added
3. to review
icewind1991
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise this might be confusing when the web UI shows a different version number than occ