Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB mounts table: Add index for mount_provider_class #33405

Merged
merged 1 commit into from
Aug 1, 2022
Merged

DB mounts table: Add index for mount_provider_class #33405

merged 1 commit into from
Aug 1, 2022

Conversation

marcelklehr
Copy link
Member

This would be necessary to select appropriate mount points to crawl files from in the proposed refactoring for recognize (for photos2.0)

@PVince81 PVince81 requested review from CarlSchwan and come-nc July 29, 2022 12:48
@marcelklehr marcelklehr force-pushed the perf/new-index-mounts-class branch from 7a3a3b3 to f61a2e3 Compare July 29, 2022 12:48
PVince81
PVince81 approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

Possible performance regression detected

Show Output 
2 queries added

≠ /remote.php/dav/files/test with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt

1 similar comment
@github-actions
Copy link
Contributor

Possible performance regression detected

Show Output 
2 queries added

≠ /remote.php/dav/files/test with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt

juliusknorr
juliusknorr requested changes Jul 29, 2022
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we add this on installation to an existing migration and rather put it to the list of indexes that get added with occ db:add-missing-indices. That way administrators can apply the index separately from the actual upgrade which is usually a good idea for larger tables.

Reference for how that can be done: abd6b35

@marcelklehr marcelklehr force-pushed the perf/new-index-mounts-class branch from f61a2e3 to 71b747e Compare August 1, 2022 11:52
@marcelklehr marcelklehr requested a review from juliusknorr August 1, 2022 11:53
@marcelklehr
DB mounts table: Add index for mount_provider_class
047cc70 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr force-pushed the perf/new-index-mounts-class branch from 71b747e to 047cc70 Compare August 1, 2022 12:27
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Possible performance regression detected

Show Output 
2 queries added

= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
≠ /remote.php/dav/files/test/many_files with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Possible performance regression detected

Show Output 
2 queries added

= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
≠ /remote.php/dav/files/test/many_files with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt

@marcelklehr
Copy link
Member Author

Maybe we add this on installation to an existing migration and rather put it to the list of indexes that get added with occ db:add-missing-indices

Good idea! I changed the PR to do this instead :)

@juliusknorr
Copy link
Member

Failures unrelated.

@juliusknorr juliusknorr merged commit e750137 into master Aug 1, 2022
@juliusknorr juliusknorr deleted the perf/new-index-mounts-class branch August 1, 2022 19:27
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
@PVince81 PVince81 added this to the Nextcloud 25 milestone Oct 25, 2022
@PVince81
Copy link
Member

/backport to stable24

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 25, 2022
Merged
1 task
@tcitworld tcitworld mentioned this pull request Nov 29, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@PVince81 PVince81 PVince81 approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@come-nc come-nc Awaiting requested review from come-nc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
4 participants
@marcelklehr @juliusknorr @PVince81 @CarlSchwan