Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always triger setup of builtin storage wrappers #33308

Merged
merged 1 commit into from
Jul 22, 2022
Merged

always triger setup of builtin storage wrappers #33308

merged 1 commit into from
Jul 22, 2022

Conversation

icewind1991
Copy link
Member

Currently, in some cases the setupBuiltinWrappers isn't triggered, leading to issues with propagation of mount options.

@icewind1991
always triger setup of builtin storage wrappers
13eef55 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jul 21, 2022
@icewind1991 icewind1991 added this to the Nextcloud 25 milestone Jul 21, 2022
@icewind1991 icewind1991 requested review from a team, blizzz, skjnldsv and come-nc and removed request for a team July 21, 2022 14:37
@icewind1991
Copy link
Member Author

/backport to stable24

@icewind1991
Copy link
Member Author

you can test this with external storages and the "check for changes" option.

  • Setup an external storage (local is sufficient)
  • Upload some files trough nextcloud
  • Delete one of the files directly on the external storage
  • Refresh the folder

blizzz
blizzz approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, and working for the use case.

PVince81
PVince81 approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 22, 2022
@blizzz
Copy link
Member

blizzz commented Jul 22, 2022

NoDB is failing but surely not related to this changes

@blizzz
Copy link
Member

blizzz commented Jul 22, 2022

NoDB is failing but surely not related to this changes

unrelated, fix in #33324, merging this one

@blizzz blizzz merged commit 7e13eec into master Jul 22, 2022
@blizzz blizzz deleted the fs-setup-builtin-wrappers branch July 22, 2022 20:20
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 22, 2022
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@come-nc come-nc Awaiting requested review from come-nc

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
3 participants
@icewind1991 @blizzz @PVince81