Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle AccessDenied error when checking if external s3 support versions #33280

Merged
merged 1 commit into from
Jul 28, 2022
Merged

handle AccessDenied error when checking if external s3 support versions #33280

merged 1 commit into from
Jul 28, 2022

Conversation

mgallien
Copy link
Contributor

Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com

@mgallien mgallien requested review from a team, icewind1991, blizzz and juliusknorr and removed request for a team July 19, 2022 14:28
@github-actions
Copy link
Contributor

Possible performance regression detected

Show Output 
1 queries added

≠ /remote.php/dav/files/test with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/test.txt
≠ /remote.php/dav/files/test/many_files with 1 queries removed
  - UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)

blizzz
blizzz approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@blizzz
Copy link
Member

blizzz commented Jul 22, 2022

/rebase

@blizzz blizzz added the 4. to release Ready to be released and/or waiting for tests to finish label Jul 22, 2022
@blizzz blizzz added this to the Nextcloud 25 milestone Jul 22, 2022
@nextcloud-command nextcloud-command force-pushed the externalStorageWithoutVersioning branch from 74a6705 to 30db5c8 Compare July 22, 2022 22:13
@PVince81
Copy link
Member

/rebase

@PVince81
Copy link
Member

rebasing as I hope to see the S3 tests pass (and as they randomly fail to init)

@nextcloud-command nextcloud-command force-pushed the externalStorageWithoutVersioning branch from 30db5c8 to 20161b2 Compare July 26, 2022 21:25
@PVince81
Copy link
Member

again

curl: (7) Failed to connect to localhost port 9000: Connection refused

😢

@mgallien
Copy link
Contributor Author

/rebase

@mgallien
handle AccessDenied error when checking if external s3 support versions
54c05bc 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@nextcloud-command nextcloud-command force-pushed the externalStorageWithoutVersioning branch from 20161b2 to 54c05bc Compare July 28, 2022 09:20
@mgallien
Copy link
Contributor Author

@PVince81 may I merge it ?
is it possible to backport it to older releases (has been reported even in v22)

@PVince81 PVince81 merged commit a1bf9b9 into master Jul 28, 2022
@PVince81 PVince81 deleted the externalStorageWithoutVersioning branch July 28, 2022 10:13
@PVince81
Copy link
Member

/backport to stable24

@PVince81
Copy link
Member

/backport to stable23

This was referenced Jul 28, 2022
Merged
Merged
@CarlSchwan
Copy link
Member

/backport to stable22

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 3, 2022
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@blizzz blizzz blizzz approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: external storage
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
5 participants
@mgallien @blizzz @PVince81 @CarlSchwan @juliusknorr