-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not redirect if requested font, style or script can not be found #33174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested review from
kesselb,
artonge,
julien-nc,
Pytal,
come-nc and
max-nextcloud
July 8, 2022 16:36
Possible performance regression detected Show Output
|
ChristophWurst
changed the title
Do not redirect if requested CSS can not be found
Do not redirect if requested font, style or script can not be found
Jul 8, 2022
Possible performance regression detected Show Output
|
Pytal
approved these changes
Jul 8, 2022
kesselb
approved these changes
Jul 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
ChristophWurst
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Jul 11, 2022
come-nc
approved these changes
Jul 11, 2022
@ChristophWurst please cleanup the commit history |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/redirect-css-not-found
branch
from
August 8, 2022 12:10
f838d20
to
a1149b0
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a page in Nextcloud requests a font, stylesheet or script that doesn't exist we currently redirect to the default page. This comes with the following consequences
The stylesheet https://localhost/apps/dashboard/ was not loaded because its MIME type, “text/html”, is not “text/css”.
User routing is not affected by this. If you navigate to
<domain>/apps/phpmymailapp
Nextcloud still redirects to the default page. That behavior is desired.Tested with FF and Chromium.
Ref https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Sec-Fetch-Dest